Repository navigation
👷 ci: run the release build on pull requests - #6
Merged
Merged
Conversation
The 0.1.0 release failed at the build step after the tag was cut, because the release build installs build requirements with hashes from the lock and the lock lacked some. Pull requests now run that same build, so the next such gap fails before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.1.0 release failed at its build step after the tag was cut. The release build installs
[build-system].requireswith--require-build-hashes, taking the hashes from the lock, and the lock lacked three packages (#3). No pull request check ran that build, so the gap only showed after merge. The existing release dry run assembles the changelog but does not build.Pull requests now run the release's own build job, the shared
validate-python-release.yamlthatrelease.yamlcalls, at the same pin. A change that would break the release build now fails the required checks before merge. 🏗️